Cursor rule

1---
2description: "Subagent task: Fix strict TypeScript errors in standalone feature files (batch B) and add to CORE_FILES"
3globs:
4  - "scripts/check-strict-core.js"
5  - "injected/src/features/duck-ai-chat-history.js"
6  - "injected/src/features/duck-ai-data-clearing.js"
7  - "injected/src/features/element-hiding.js"
8  - "injected/src/features/page-context.js"
9  - "injected/src/features/ua-ch-brands.js"
10---
11 
12# Strict TypeScript: Standalone Features B
13 
14## Task
15 
16Fix all strict-mode TypeScript errors in 5 standalone feature files and add them to `CORE_FILES`.
17 
18## Branch
19 
20```
21git checkout main && git pull origin main && git checkout -b cursor/strict/standalone-features-b
22```
23 
24## Files (53 errors total)
25 
26### `injected/src/features/duck-ai-chat-history.js` (11 errors)
27```
28(25,13): error TS2322: Type 'Promise<void>' is not assignable to type 'void'.
29(51,31): error TS2339: Property 'message' does not exist on type '{}'.
30(227,22): error TS2339: Property 'pinned' does not exist on type 'object'.
31(244,30): error TS2339: Property 'lastEdit' does not exist on type 'object'.
32(250,27): error TS2339: Property 'chatId' does not exist on type 'object'.
33(251,26): error TS2339: Property 'title' does not exist on type 'object'.
34(252,26): error TS2339: Property 'model' does not exist on type 'object'.
35(254,27): error TS2339: Property 'pinned' does not exist on type 'object'.
36(265,35): error TS2339: Property 'title' does not exist on type 'object'.
37(265,61): error TS2339: Property 'title' does not exist on type 'object'.
38(277,31): error TS2339: Property 'lastEdit' does not exist on type 'object'.
39```
40 
41### `injected/src/features/duck-ai-data-clearing.js` (5 errors)
42```
43(14,110): error TS2322: Type 'Promise<void>' is not assignable to type 'void'.
44(92,29): error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Error'.
45(111,29): error TS2345: Argument of type 'unknown' is not assignable to parameter of type 'Error'.
46(153,41): error TS7006: Parameter 'chat' implicitly has an 'any' type.
47(163,23): error TS7006: Parameter 'localStorageKey' implicitly has an 'any' type.
48```
49 
50### `injected/src/features/element-hiding.js` (11 errors)
51```
52(56,5): TS7034: Variable 'adLabelStrings' implicitly has type 'any[]'.
53(227,32): TS7005: Variable 'adLabelStrings' implicitly has an 'any[]' type.
54(270,11): TS7034: Variable 'strictHideRules' implicitly has type 'any[]'.
55(271,11): TS7034: Variable 'timeoutRules' implicitly has type 'any[]'.
56(281,20): TS7005: Variable 'strictHideRules' implicitly has an 'any[]' type.
57(282,12): TS7005: Variable 'timeoutRules' implicitly has an 'any[]' type.
58(348,28): TS7006: Parameter 'selector' implicitly has an 'any' type.
59(361,13): TS7034: Variable 'activeRules' implicitly has type 'any'.
60(406,31): TS2345: Argument of type callback not assignable.
61(407,27): TS7005: Variable 'activeRules' implicitly has an 'any' type.
62(417,28): TS7005: Variable 'activeRules' implicitly has an 'any' type.
63```
64 
65### `injected/src/features/page-context.js` (19 errors)
66```
67(10,36): TS7006: Parameter 'node' implicitly has an 'any' type.
68(24,29): TS7006: Parameter 'str' implicitly has an 'any' type.
69(196,26): TS7006: Parameter 'str' implicitly has an 'any' type.
70(205,22): TS7006: Parameter 'node' implicitly has an 'any' type.
71(205,28): TS7006: Parameter 'children' implicitly has an 'any' type.
72(205,38): TS7006: Parameter 'settings' implicitly has an 'any' type.
73(484,21): TS2339: Property 'metaDescription' does not exist on type.
74(487,21): TS2339: Property 'headings' does not exist on type.
75(490,21): TS2339: Property 'links' does not exist on type.
76(493,21): TS2339: Property 'images' does not exist on type.
77(553,33): TS7006: Parameter 'root' implicitly has an 'any' type.
78(592,15): TS7034: Variable 'headings' implicitly has type 'any[]'.
79(604,16): TS7005: Variable 'headings' implicitly has an 'any[]' type.
80(608,15): TS7034: Variable 'links' implicitly has type 'any[]'.
81(620,16): TS7005: Variable 'links' implicitly has an 'any[]' type.
82(624,15): TS7034: Variable 'images' implicitly has type 'any[]'.
83(636,16): TS7005: Variable 'images' implicitly has an 'any[]' type.
84(639,25): TS7006: Parameter 'content' implicitly has an 'any' type.
85(652,23): TS7006: Parameter 'error' implicitly has an 'any' type.
86```
87 
88### `injected/src/features/ua-ch-brands.js` (7 errors)
89```
90(5,17): TS7006: Parameter 'featureName' implicitly has an 'any' type.
91(5,30): TS7006: Parameter 'importConfig' implicitly has an 'any' type.
92(5,44): TS7006: Parameter 'features' implicitly has an 'any' type.
93(5,54): TS7006: Parameter 'args' implicitly has an 'any' type.
94(96,37): TS2532: Object is possibly 'undefined'.
95(133,75): TS2683: 'this' implicitly has type 'any'.
96(147,21): TS7053: Element implicitly has an 'any' type (string index on {}).
97```
98 
99## Fix Patterns
100 
101- **TS2339 on `object`/`{}`**: Define proper `@typedef` for chat history entries, page context data shapes.
102- **TS2322 (Promise<void> → void)**: The function signature expects `void` return but the method is `async`. Either mark the return type as `void | Promise<void>` or handle the promise.
103- **TS7034/TS7005** (implicit any arrays): Add `/** @type {string[]} */` or appropriate typed array annotation.
104- **TS7006**: Add `@param` JSDoc annotations.
105- **TS2345**: Type guards or casts for argument mismatches.
106- **TS2683**: Arrow function or `@this {Type}` annotation.
107- **TS2532**: Null/undefined guards.
108 
109## Workflow
110 
1111. `npm ci`
1122. Add all 5 files to CORE_FILES in `scripts/check-strict-core.js`
1133. Fix each file's errors
1144. `npm run tsc-strict-core` — must pass
1155. `npm run test-unit` — must pass
1166. `npm run lint` — must pass (run `npm run lint-fix` first if needed)
1177. Commit: `fix(types): add strict checking for standalone feature files (batch B)`
1188. `git push -u origin cursor/strict/standalone-features-b`
119 
120## Constraints
121 
122- Do NOT use `any` — use `unknown`, specific types, or proper interfaces
123- Do NOT use `@ts-ignore` or `@ts-expect-error`
124- Do NOT modify files outside the assigned list (except `scripts/check-strict-core.js`)
125- Do NOT remove existing CORE_FILES entries
126- Preserve existing behavior — type fixes only, no logic changes
127