Cursor rule

1---
2description: "Subagent task: Fix strict TypeScript errors in click-to-load files and add to CORE_FILES"
3globs:
4  - "scripts/check-strict-core.js"
5  - "injected/src/features/click-to-load.js"
6  - "injected/src/features/click-to-load/components/ctl-login-button.js"
7---
8 
9# Strict TypeScript: Click-to-Load
10 
11## Task
12 
13Fix all strict-mode TypeScript errors in 2 click-to-load files and add them to `CORE_FILES`. This is the largest single-file effort (169 errors in click-to-load.js).
14 
15## Branch
16 
17```
18git checkout main && git pull origin main && git checkout -b cursor/strict/click-to-load
19```
20 
21## Files (170 errors total)
22 
23### `injected/src/features/click-to-load.js` (169 errors)
24 
25**Key error categories:**
26 
271. **Variables `styles`, `sharedStrings`, `config`, `appID`, `entities`, `readyToDisplayPlaceholdersResolver`, `afterPageLoadResolver` implicitly any (TS7034/TS7005)** — ~100 errors. These module-level variables are initialized as `undefined`/empty and assigned later. Add explicit `/** @type {X} */` at declaration.
28 
292. **Property access on `Object` or `{}` typed params (TS2339/TS7053)** — ~30 errors. Config objects need proper typing. Define `@typedef` for the config shape, element data, etc.
30 
313. **Parameter implicitly any (TS7006)** — ~5 errors. Add `@param` annotations.
32 
334. **Type incompatibility (TS2322)** — `(originalElement: HTMLIFrameElement, ...)` vs `(originalElement: HTMLElement | HTMLIFrameElement, ...)`. Widen the parameter type.
34 
355. **`this` implicitly any (TS2683)** — Arrow functions or explicit `@this` annotations.
36 
376. **Cannot invoke possibly null (TS2721)** — Add null checks before invoking.
38 
397. **No initializer (TS2564)** — `#messagingContext` property. Add `!` definite assignment assertion or initialize.
40 
418. **displayMode index (TS7053)** — Cast the enum/string to the correct key type.
42 
43**Strategy for `styles` variable (~80 of the 169 errors):** The `styles` variable is used extensively. Find where it's assigned (likely from config) and type it with a comprehensive `@typedef` capturing all style properties used throughout the file. A single proper type annotation at the declaration eliminates ~80 errors.
44 
45**Strategy for `sharedStrings`:** Same approach — find the shape from config and type it.
46 
47### `injected/src/features/click-to-load/components/ctl-login-button.js` (1 error)
48```
49(23,5): error TS2564: Property '#element' has no initializer and is not definitely assigned in the constructor.
50```
51 
52## Full Error List for click-to-load.js
53 
54```
55(31,5): TS7034: Variable 'appID' implicitly has type 'any'
56(37,5): TS7034: Variable 'config' implicitly has type 'any'
57(38,5): TS7034: Variable 'sharedStrings' implicitly has type 'any'
58(39,5): TS7034: Variable 'styles' implicitly has type 'any'
59(60,7): TS7034: Variable 'entities' implicitly has type 'any[]'
60(69,5): TS7034: Variable 'readyToDisplayPlaceholdersResolver' implicitly has type 'any'
61(77,5): TS7034: Variable 'afterPageLoadResolver' implicitly has type 'any'
62(119,44): TS2339: Property 'clickAction' does not exist on type 'Object'
63(120,43): TS2339: Property 'replaceSettings' does not exist on type 'Object'
64(122,9): TS7008: Member 'placeholderElement' implicitly has an 'any' type
65(195,13): TS7053: Element implicitly has an 'any' type (string index on {})
66(238,34): TS7053: Element implicitly has an 'any' type
67(240,34): TS7053: Element implicitly has an 'any' type
68(268,31): TS2339: Property 'app_id_replace' does not exist on type '{}'
69(268,49): TS7005: Variable 'appID' implicitly has an 'any' type
70(269,95): TS7005: Variable 'appID' implicitly has an 'any' type
71(273,29): TS7053: Element implicitly has an 'any' type
72(330,24): TS7006: Parameter 'event' implicitly has an 'any' type
73(414,30): TS7006: Parameter 'e' implicitly has an 'any' type
74(450,49): TS7005: Variable 'styles' implicitly has an 'any' type
75(456,52): TS7053: Element implicitly has an 'any' type (displayMode index)
76(458,48): TS7005: Variable 'styles' implicitly has an 'any' type
77(520,60): TS7053: Element implicitly has an 'any' type
78(521,21): TS7006: Parameter 'e' implicitly has an 'any' type
79(644-1964): ~140 more errors, mostly TS7005 for 'styles' and 'sharedStrings' variables
80(1788,5): TS2564: Property '#messagingContext' has no initializer
81(1792,16): TS7006: Parameter 'args' implicitly has an 'any' type
82(1823-1867): TS7053/TS2339 on config entity indexing
83(1894-1950): TS7005 for 'afterPageLoadResolver' and 'readyToDisplayPlaceholdersResolver'
84(1905,13): TS2721: Cannot invoke possibly null
85(1911,13): TS2721: Cannot invoke possibly null
86(1921,12): TS7006: Parameter 'message' implicitly has an 'any' type
87(1963-1964): TS7005 for 'config'
88```
89 
90## Fix Patterns
91 
92- **Module-level variables**: Add `/** @type {X | undefined} */` where `X` is derived from usage. For `styles`, trace to where it's populated from config.
93- **TS2564**: Use `/** @type {X} */ (#prop)` or add definite assignment `!` in declaration.
94- **TS2339 on Object**: Define proper `@typedef` for the config/entity shapes.
95- **TS2322 (HTMLIFrameElement vs union)**: Widen parameter to `HTMLElement | HTMLIFrameElement`.
96- **TS2683 (this)**: Convert to arrow function or add `@this {Type}`.
97- **TS2721**: Guard with `if (resolver) resolver()`.
98 
99## Workflow
100 
1011. `npm ci`
1022. Add both files to CORE_FILES in `scripts/check-strict-core.js`
1033. Fix errors — start with the `styles` and `sharedStrings` typedefs to eliminate bulk errors
1044. `npm run tsc-strict-core` — must pass
1055. `npm run test-unit` — must pass
1066. `npm run lint` — must pass (run `npm run lint-fix` first if needed)
1077. Commit: `fix(types): add strict checking for click-to-load files`
1088. `git push -u origin cursor/strict/click-to-load`
109 
110## Constraints
111 
112- Do NOT use `any` — use `unknown`, specific types, or proper interfaces
113- Do NOT use `@ts-ignore` or `@ts-expect-error`
114- Do NOT modify files outside the assigned list (except `scripts/check-strict-core.js`)
115- Do NOT remove existing CORE_FILES entries
116- Preserve existing behavior — type fixes only, no logic changes
117