Cursor rule

1---
2description: "Subagent task: Fix strict TypeScript errors in remaining broker-protection files and add to CORE_FILES"
3globs:
4  - "scripts/check-strict-core.js"
5  - "injected/src/features/broker-protection.js"
6  - "injected/src/features/broker-protection/captcha-services/captcha.service.js"
7  - "injected/src/features/broker-protection/captcha-services/providers/cloudflare-turnstile.js"
8  - "injected/src/features/broker-protection/comparisons/address.js"
9  - "injected/src/features/broker-protection/comparisons/is-same-age.js"
10  - "injected/src/features/broker-protection/execute.js"
11  - "injected/src/features/broker-protection/extractors/address.js"
12  - "injected/src/features/broker-protection/utils/utils.js"
13---
14 
15# Strict TypeScript: Broker Protection (Rest)
16 
17## Task
18 
19Fix all strict-mode TypeScript errors in 8 remaining broker-protection files and add them to `CORE_FILES`.
20 
21## Branch
22 
23```
24git checkout main && git pull origin main && git checkout -b cursor/strict/broker-protection-rest
25```
26 
27## Files (22 errors total)
28 
29### `injected/src/features/broker-protection.js` (3 errors)
30```
31(44,66): error TS18046: 'e' is of type 'unknown'.
32(80,20): error TS7006: Parameter 'action' implicitly has an 'any' type.
33(121,43): error TS7006: Parameter 'x' implicitly has an 'any' type.
34```
35 
36### `injected/src/features/broker-protection/captcha-services/captcha.service.js` (1 error)
37```
38(80,26): error TS2345: Argument of type 'string | PirError' is not assignable to parameter of type 'object'.
39```
40 
41### `injected/src/features/broker-protection/captcha-services/providers/cloudflare-turnstile.js` (4 errors)
42```
43(74,30): error TS2345: Argument of type 'string | PirError' is not assignable to parameter of type 'object'.
44(82,30): error TS2345: Argument of type 'HTMLElement | PirError | null' is not assignable to parameter of type 'object'.
45(111,30): error TS2345: Argument of type 'string | PirError' is not assignable to parameter of type 'object'.
46(122,24): error TS7015: Element implicitly has an 'any' type because index expression is not of type 'number'.
47```
48 
49### `injected/src/features/broker-protection/comparisons/address.js` (2 errors)
50```
51(17,42): error TS7006: Parameter 'stateAbbreviation' implicitly has an 'any' type.
52(24,12): error TS7053: Element implicitly has an 'any' type because expression of type 'any' can't be used to index type (US state map).
53```
54 
55### `injected/src/features/broker-protection/comparisons/is-same-age.js` (2 errors)
56```
57(6,27): error TS7006: Parameter 'userAge' implicitly has an 'any' type.
58(6,36): error TS7006: Parameter 'ageFound' implicitly has an 'any' type.
59```
60 
61### `injected/src/features/broker-protection/execute.js` (1 error)
62```
63(43,46): error TS18046: 'e' is of type 'unknown'.
64```
65 
66### `injected/src/features/broker-protection/extractors/address.js` (1 error)
67```
68(4,26): error TS7016: Could not find a declaration file for module 'parse-address'.
69```
70 
71### `injected/src/features/broker-protection/utils/utils.js` (8 errors)
72```
73(101,40): error TS7006: Parameter 'selector' implicitly has an 'any' type.
74(116,37): error TS7006: Parameter 'selector' implicitly has an 'any' type.
75(132,42): error TS7006: Parameter 'selector' implicitly has an 'any' type.
76(151,45): error TS7006: Parameter 'selector' implicitly has an 'any' type.
77(239,13): error TS2314: Generic type 'Array<T>' requires 1 type argument(s).
78(242,28): error TS7006: Parameter 'a' implicitly has an 'any' type.
79(242,31): error TS7006: Parameter 'b' implicitly has an 'any' type.
80(256,34): error TS7006: Parameter 'profile' implicitly has an 'any' type.
81```
82 
83## Fix Patterns
84 
85- **TS7006** (Parameter implicitly any): Add `@param {Type}` JSDoc.
86- **TS18046** ('e' is unknown): Use `error instanceof Error ? error.message : String(error)` pattern.
87- **TS2345** (Argument not assignable): Narrow types with guards or adjust the function signature upstream.
88- **TS7016** (No declaration file for module): Add `// @ts-ignore` only as last resort, or create a minimal `.d.ts` declaration in the project. Better: use `/** @type {import('parse-address')} */` if types exist, or `/** @type {Record<string, Function>} */` for the default import.
89- **TS2314** (Generic requires type args): Change `Array` → `Array<string>` or appropriate type.
90- **TS7053/TS7015** (No index signature): Cast with `Record<string, X>` or narrow the index.
91 
92## Workflow
93 
941. `npm ci`
952. Add all 8 files to CORE_FILES in `scripts/check-strict-core.js`
963. Fix each file's errors
974. `npm run tsc-strict-core` — must pass
985. `npm run test-unit` — must pass
996. `npm run lint` — must pass (run `npm run lint-fix` first if needed)
1007. Commit: `fix(types): add strict checking for broker-protection files`
1018. `git push -u origin cursor/strict/broker-protection-rest`
102 
103## Constraints
104 
105- Do NOT use `any` — use `unknown`, specific types, or proper interfaces
106- Do NOT use `@ts-ignore` or `@ts-expect-error` (except for the `parse-address` module if no types exist)
107- Do NOT modify files outside the assigned list (except `scripts/check-strict-core.js`)
108- Do NOT remove existing CORE_FILES entries
109- Preserve existing behavior — type fixes only, no logic changes
110