Cursor rule

1---
2description: "Subagent task: Fix strict TypeScript errors in standalone feature files (batch A) and add to CORE_FILES"
3globs:
4  - "scripts/check-strict-core.js"
5  - "injected/src/features/api-manipulation.js"
6  - "injected/src/features/autofill-import.js"
7  - "injected/src/features/breakage-reporting.js"
8  - "injected/src/features/breakage-reporting/utils.js"
9  - "injected/src/features/cookie.js"
10  - "injected/src/features/harmful-apis.js"
11  - "injected/src/features/windows-permission-usage.js"
12---
13 
14# Strict TypeScript: Standalone Features A
15 
16## Task
17 
18Fix all strict-mode TypeScript errors in 7 standalone feature files and add them to `CORE_FILES`.
19 
20## Branch
21 
22```
23git checkout main && git pull origin main && git checkout -b cursor/strict/standalone-features-a
24```
25 
26## Files (108 errors total)
27 
28### `injected/src/features/api-manipulation.js` (8 errors)
29```
30(101,24): error TS7053: Element implicitly has an 'any' type (string index on {}).
31(119,28): error TS2339: Property 'enumerable' does not exist on type '{ get: () => any; }'.
32(122,28): error TS2339: Property 'configurable' does not exist on type '{ get: () => any; }'.
33(129,51): error TS2339: Property 'enumerable' does not exist on type '{ get: () => any; }'.
34(129,96): error TS2339: Property 'enumerable' does not exist on type '{ get: () => any; }'.
35(130,53): error TS2339: Property 'configurable' does not exist on type '{ get: () => any; }'.
36(130,100): error TS2339: Property 'configurable' does not exist on type '{ get: () => any; }'.
37(153,23): error TS7015: Element implicitly has an 'any' type because index expression is not of type 'number'.
38```
39 
40### `injected/src/features/autofill-import.js` (23 errors)
41```
42(39,5): TS7008: Member '#exportButtonSettings' implicitly has an 'any' type.
43(41,5): TS7008: Member '#settingsButtonSettings' implicitly has an 'any' type.
44(43,5): TS7008: Member '#signInButtonSettings' implicitly has an 'any' type.
45(45,5): TS7008: Member '#exportConfirmButtonSettings' implicitly has an 'any' type.
46(48,5): TS2564: Property '#elementToCenterOn' has no initializer.
47(51,5): TS2564: Property '#currentOverlay' has no initializer.
48(54,5): TS2564: Property '#currentElementConfig' has no initializer.
49(56,5): TS7008: Member '#domLoaded' implicitly has an 'any' type.
50(58,5): TS7008: Member '#processingBookmark' implicitly has an 'any' type.
51(144,24): TS7006: Parameter 'fn' implicitly has an 'any' type.
52(387,20): TS7006: Parameter 'element' implicitly has an 'any' type.
53(469,37): TS7006: Parameter 'pathname' implicitly has an 'any' type.
54(561,60): TS7006: Parameter 'text' implicitly has an 'any' type.
55(568,60): TS7006: Parameter 'text' implicitly has an 'any' type.
56(582,62): TS7006: Parameter 'text' implicitly has an 'any' type.
57(636,20): TS7006: Parameter '_' implicitly has an 'any' type.
58(644,31): TS7006: Parameter 'name' implicitly has an 'any' type.
59(644,37): TS7006: Parameter 'data' implicitly has an 'any' type.
60(645,20): TS7017: Element implicitly has an 'any' type (globalThis).
61(653,36): TS7006: Parameter 'action' implicitly has an 'any' type.
62(660,36): TS7006: Parameter 'pathname' implicitly has an 'any' type.
63(685,50): TS2769: No overload matches this call.
64(688,16): TS18048: 'exportPanel' is possibly 'undefined'.
65```
66 
67### `injected/src/features/breakage-reporting.js` (8 errors)
68```
69(26,24): TS2339: Property 'opener' does not exist on type '{ jsPerformance: number[]; referrer: string; }'.
70(30,24): TS2339: Property 'pageReloaded' does not exist on type.
71(46,24): TS2339: Property 'detectorData' does not exist on type.
72(57,28): TS2339: Property 'expandedPerformanceMetrics' does not exist on type.
73(61,24): TS2339: Property 'detectorData' does not exist on type.
74(62,59): TS2339: Property 'detectorData' does not exist on type.
75(66,28): TS2339: Property 'breakageData' does not exist on type.
76(69,28): TS2339: Property 'breakageData' does not exist on type.
77```
78 
79### `injected/src/features/breakage-reporting/utils.js` (5 errors)
80```
81(48,13): TS7034: Variable 'timeoutId' implicitly has type 'any'.
82(50,13): TS7034: Variable 'observer' implicitly has type 'any'.
83(53,17): TS7005: Variable 'observer' implicitly has an 'any' type.
84(54,17): TS7005: Variable 'timeoutId' implicitly has an 'any' type.
85(147,61): TS18046: 'e' is of type 'unknown'.
86```
87 
88### `injected/src/features/cookie.js` (8 errors)
89```
90(48,5): TS7034: Variable 'loadedPolicyResolve' implicitly has type 'any'.
91(125,72): TS7006: Parameter 'exception' implicitly has an 'any' type.
92(217,95): TS2532: Object is possibly 'undefined'.
93(244,10): TS7006: Parameter 'args' implicitly has an 'any' type.
94(263,21): TS7053: Element implicitly has an 'any' type (string index on config type).
95(264,21): TS7053: Element implicitly has an 'any' type.
96(264,41): TS7053: Element implicitly has an 'any' type.
97(269,9): TS7005: Variable 'loadedPolicyResolve' implicitly has an 'any' type.
98```
99 
100### `injected/src/features/harmful-apis.js` (29 errors)
101 
102**Error categories:**
103- TS7017 (globalThis no index signature): 16 errors — lines 23, 107, 109, 126, 230, 233, 236, 272, 282, 288, 299, 311, 324, 348, 361, 364, 367
104- TS2683 ('this' implicitly any): 8 errors — lines 55, 88, 92, 114, 127, 272, 275, 385
105- TS7006 (param implicitly any): 2 errors — lines 136, 161
106- TS7053 (string index on {}): 1 error — line 191
107- TS2532 (possibly undefined): 1 error — line 388
108 
109### `injected/src/features/windows-permission-usage.js` (27 errors)
110 
111**Error categories:**
112- TS7006 (param implicitly any): 19 errors — various parameter types needed
113- TS7034/TS7005 (variable implicitly any): 4 errors — timer variables
114- TS7017 (globalThis): 4 errors — lines 386-389
115 
116## Fix Patterns
117 
118- **TS7006/TS7008**: Add `@param` or `@type` JSDoc annotations.
119- **TS2339**: Extend the type definition to include missing properties, or define proper `@typedef`.
120- **TS7017 (globalThis)**: Use `/** @type {Record<string, unknown>} */ (globalThis)` or assign to typed variable.
121- **TS2683 ('this' implicitly any)**: Use arrow functions or add `@this {Type}` annotation.
122- **TS2564**: Definite assignment assertion or initialize.
123- **TS7034/TS7005**: Add explicit type at declaration.
124- **TS18046/TS18048**: Type guards for unknown/undefined.
125- **TS2769**: Check overload signatures, narrow types.
126 
127## Workflow
128 
1291. `npm ci`
1302. Add all 7 files to CORE_FILES in `scripts/check-strict-core.js`
1313. Fix each file's errors
1324. `npm run tsc-strict-core` — must pass
1335. `npm run test-unit` — must pass
1346. `npm run lint` — must pass (run `npm run lint-fix` first if needed)
1357. Commit: `fix(types): add strict checking for standalone feature files (batch A)`
1368. `git push -u origin cursor/strict/standalone-features-a`
137 
138## Constraints
139 
140- Do NOT use `any` — use `unknown`, specific types, or proper interfaces
141- Do NOT use `@ts-ignore` or `@ts-expect-error`
142- Do NOT modify files outside the assigned list (except `scripts/check-strict-core.js`)
143- Do NOT remove existing CORE_FILES entries
144- Preserve existing behavior — type fixes only, no logic changes
145