Cursor rule

1---
2description: "Subagent task: Fix strict TypeScript errors in message-bridge files and add to CORE_FILES"
3globs:
4  - "scripts/check-strict-core.js"
5  - "injected/src/features/message-bridge.js"
6  - "injected/src/features/message-bridge/create-page-world-bridge.js"
7  - "injected/src/features/message-bridge/schema.js"
8---
9 
10# Strict TypeScript: Message Bridge
11 
12## Task
13 
14Fix all strict-mode TypeScript errors in 3 message-bridge files and add them to `CORE_FILES`.
15 
16## Branch
17 
18```
19git checkout main && git pull origin main && git checkout -b cursor/strict/message-bridge
20```
21 
22## Files (62 errors total)
23 
24### `injected/src/features/message-bridge.js` (5 errors)
25```
26(48,10): error TS7006: Parameter 'args' implicitly has an 'any' type.
27(84,22): error TS2769: No overload matches this call.
28(157,35): error TS18046: 'e' is of type 'unknown'.
29(181,63): error TS2345: Argument of type '(data: Record<string, any>) => void' is not assignable to parameter of type '(value: unknown) => void'.
30(215,10): error TS7006: Parameter '_args' implicitly has an 'any' type.
31```
32 
33### `injected/src/features/message-bridge/create-page-world-bridge.js` (6 errors)
34```
35(86,18): error TS2769: No overload matches this call.
36(89,14): error TS2769: No overload matches this call.
37(161,34): error TS2769: No overload matches this call.
38(164,26): error TS2769: No overload matches this call.
39(197,22): error TS2769: No overload matches this call.
40(200,26): error TS2769: No overload matches this call.
41```
42 
43### `injected/src/features/message-bridge/schema.js` (51 errors)
44All TS2339 — Property does not exist on type 'Object'. The schema validation functions receive `Object` typed params but access specific properties:
45```
46Properties accessed: featureName, id, method, params, result, error, subscriptionName
47Lines: 32-34, 56-57, 84-92, 122-132, 161-167, 193-199, 227-235, 257-259
48```
49 
50## Fix Patterns
51 
52### schema.js Strategy (51 errors)
53The schema.js file validates message shapes. Each validation function receives an `Object` parameter but needs to access typed properties. **Define `@typedef` types for each message shape:**
54 
55```js
56/**
57 * @typedef {Object} NotifyMessage
58 * @property {string} featureName
59 * @property {string} id
60 */
61 
62/**
63 * @typedef {Object} RequestMessage
64 * @property {string} featureName
65 * @property {string} method
66 * @property {string} id
67 * @property {unknown} [params]
68 */
69 
70/**
71 * @typedef {Object} ResponseMessage
72 * @property {string} featureName
73 * @property {string} method
74 * @property {string} id
75 * @property {unknown} [result]
76 * @property {unknown} [error]
77 */
78 
79/**
80 * @typedef {Object} SubscriptionMessage
81 * @property {string} featureName
82 * @property {string} subscriptionName
83 * @property {string} id
84 * @property {unknown} [params]
85 */
86```
87 
88Then cast each validation function's input parameter.
89 
90### create-page-world-bridge.js (6 errors)
91All TS2769 "No overload matches" — likely addEventListener/postMessage calls with custom event types. Check the actual event type strings and cast or use proper event map overloads.
92 
93### message-bridge.js (5 errors)
94- TS7006: Add `@param` annotations.
95- TS2769: Same overload pattern as above.
96- TS18046: `instanceof Error` check or `String(e)`.
97- TS2345: Cast callback or widen type.
98 
99## Workflow
100 
1011. `npm ci`
1022. Add all 3 files to CORE_FILES in `scripts/check-strict-core.js`
1033. Fix schema.js first (bulk errors), then the other two
1044. `npm run tsc-strict-core` — must pass
1055. `npm run test-unit` — must pass
1066. `npm run lint` — must pass (run `npm run lint-fix` first if needed)
1077. Commit: `fix(types): add strict checking for message-bridge files`
1088. `git push -u origin cursor/strict/message-bridge`
109 
110## Constraints
111 
112- Do NOT use `any` — use `unknown`, specific types, or proper interfaces
113- Do NOT use `@ts-ignore` or `@ts-expect-error`
114- Do NOT modify files outside the assigned list (except `scripts/check-strict-core.js`)
115- Do NOT remove existing CORE_FILES entries
116- Preserve existing behavior — type fixes only, no logic changes
117