Cursor rule

1---
2description: "Subagent task: Fix strict TypeScript errors in duckplayer-native files and add to CORE_FILES"
3globs:
4  - "scripts/check-strict-core.js"
5  - "injected/src/features/duck-player-native.js"
6  - "injected/src/features/duckplayer-native/custom-error/custom-error.js"
7  - "injected/src/features/duckplayer-native/messages.js"
8  - "injected/src/features/duckplayer-native/overlays/thumbnail-overlay.js"
9  - "injected/src/features/duckplayer-native/sub-features/duck-player-native-no-cookie.js"
10  - "injected/src/features/duckplayer-native/sub-features/duck-player-native-youtube.js"
11  - "injected/src/features/duckplayer-native/youtube-errors.js"
12---
13 
14# Strict TypeScript: DuckPlayer Native
15 
16## Task
17 
18Fix all strict-mode TypeScript errors in 7 duckplayer-native files and add them to `CORE_FILES`.
19 
20## Branch
21 
22```
23git checkout main && git pull origin main && git checkout -b cursor/strict/duckplayer-native
24```
25 
26## Files (20 errors total)
27 
28### `injected/src/features/duck-player-native.js` (4 errors)
29```
30(28,5): error TS2564: Property 'currentPage' has no initializer.
31(30,5): error TS2564: Property 't' has no initializer.
32(32,16): error TS7006: Parameter 'args' implicitly has an 'any' type.
33(53,27): error TS2322: Type 'string | undefined' is not assignable to type 'string'.
34```
35 
36### `injected/src/features/duckplayer-native/custom-error/custom-error.js` (2 errors)
37```
38(26,5): error TS2564: Property 'logger' has no initializer.
39(30,5): error TS2564: Property 'error' has no initializer.
40```
41 
42### `injected/src/features/duckplayer-native/messages.js` (3 errors)
43```
44(67,75): error TS2345: Argument of type '(mediaControlSettings: MediaControlSettings) => void' is not assignable to parameter of type '(value: unknown) => void'.
45(75,72): error TS2345: Argument of type '(muteSettings: MuteSettings) => void' is not assignable to parameter of type '(value: unknown) => void'.
46(83,72): error TS2345: Argument of type '(urlSettings: UrlChangeSettings) => void' is not assignable to parameter of type '(value: unknown) => void'.
47```
48 
49### `injected/src/features/duckplayer-native/overlays/thumbnail-overlay.js` (3 errors)
50```
51(16,5): error TS2564: Property 'logger' has no initializer.
52(20,5): error TS2564: Property 'container' has no initializer.
53(22,5): error TS2564: Property 'href' has no initializer.
54```
55 
56### `injected/src/features/duckplayer-native/sub-features/duck-player-native-no-cookie.js` (1 error)
57```
58(43,30): error TS7006: Parameter 'timestamp' implicitly has an 'any' type.
59```
60 
61### `injected/src/features/duckplayer-native/sub-features/duck-player-native-youtube.js` (1 error)
62```
63(56,30): error TS7006: Parameter 'timestamp' implicitly has an 'any' type.
64```
65 
66### `injected/src/features/duckplayer-native/youtube-errors.js` (6 errors)
67```
68(50,9): error TS2322: Type 'YouTubeError | undefined' is not assignable to type 'YouTubeError'.
69(62,57): error TS2339: Property 'get' does not exist on type 'object'.
70(80,17): error TS2322: Type 'YouTubeError | undefined' is not assignable to type 'YouTubeError'.
71(85,13): error TS2322: Type 'YouTubeError | undefined' is not assignable to type 'YouTubeError'.
72(93,13): error TS2322: Type 'YouTubeError | undefined' is not assignable to type 'YouTubeError'.
73(101,5): error TS2322: Type 'YouTubeError | undefined' is not assignable to type 'YouTubeError'.
74```
75 
76## Fix Patterns
77 
78- **TS2564** (No initializer): Use `/** @type {X} */ (prop!)` or initialize. For class properties assigned in `init()` rather than constructor, use definite assignment assertion.
79- **TS7006** (Parameter implicitly any): Add `@param {Type}` JSDoc.
80- **TS2345** (Subscribe callback): The messaging `subscribe` expects `(value: unknown) => void`. Cast or add type guard inside the callback.
81- **TS2322** (YouTubeError | undefined → YouTubeError): Add undefined checks or use non-null assertion where the value is guaranteed.
82- **TS2339** (Property 'get' on object): Cast to `Map` or the actual type that has `.get()`.
83 
84## Workflow
85 
861. `npm ci`
872. Add all 7 files to CORE_FILES in `scripts/check-strict-core.js`
883. Fix each file's errors
894. `npm run tsc-strict-core` — must pass
905. `npm run test-unit` — must pass
916. `npm run lint` — must pass (run `npm run lint-fix` first if needed)
927. Commit: `fix(types): add strict checking for duckplayer-native files`
938. `git push -u origin cursor/strict/duckplayer-native`
94 
95## Constraints
96 
97- Do NOT use `any` — use `unknown`, specific types, or proper interfaces
98- Do NOT use `@ts-ignore` or `@ts-expect-error`
99- Do NOT modify files outside the assigned list (except `scripts/check-strict-core.js`)
100- Do NOT remove existing CORE_FILES entries
101- Preserve existing behavior — type fixes only, no logic changes
102