Cursor rule

1---
2description: "Subagent task: Fix strict TypeScript errors in duckplayer files and add to CORE_FILES"
3globs:
4  - "scripts/check-strict-core.js"
5  - "injected/src/features/duck-player.js"
6  - "injected/src/features/duckplayer/components/ddg-video-drawer-mobile.js"
7  - "injected/src/features/duckplayer/components/ddg-video-overlay.js"
8  - "injected/src/features/duckplayer/environment.js"
9  - "injected/src/features/duckplayer/icon-overlay.js"
10  - "injected/src/features/duckplayer/overlay-messages.js"
11  - "injected/src/features/duckplayer/thumbnails.js"
12  - "injected/src/features/duckplayer/util.js"
13  - "injected/src/features/duckplayer/video-overlay.js"
14---
15 
16# Strict TypeScript: DuckPlayer
17 
18## Task
19 
20Fix all strict-mode TypeScript errors in 9 DuckPlayer files and add them to `CORE_FILES`.
21 
22## Branch
23 
24```
25git checkout main && git pull origin main && git checkout -b cursor/strict/duckplayer
26```
27 
28## Files (41 errors total)
29 
30### `injected/src/features/duck-player.js` (1 error)
31```
32(63,10): error TS7006: Parameter 'args' implicitly has an 'any' type.
33```
34 
35### `injected/src/features/duckplayer/components/ddg-video-drawer-mobile.js` (3 errors)
36```
37(31,5): error TS2564: Property 'container' has no initializer.
38(33,5): error TS2564: Property 'drawer' has no initializer.
39(35,5): error TS2564: Property 'overlay' has no initializer.
40```
41 
42### `injected/src/features/duckplayer/components/ddg-video-overlay.js` (2 errors)
43```
44(121,32): error TS7006: Parameter 'e' implicitly has an 'any' type.
45(128,39): error TS7006: Parameter 'e' implicitly has an 'any' type.
46```
47 
48### `injected/src/features/duckplayer/environment.js` (2 errors)
49```
50(53,26): error TS7006: Parameter 'videoId' implicitly has an 'any' type.
51(58,13): error TS7006: Parameter 'href' implicitly has an 'any' type.
52```
53 
54### `injected/src/features/duckplayer/icon-overlay.js` (10 errors)
55```
56(76,47): error TS2339: Property 'top' does not exist on type 'Object'.
57(76,91): error TS2339: Property 'left' does not exist on type 'Object'.
58(135,22): error TS7006: Parameter 'event' implicitly has an 'any' type.
59(135,29): error TS7006: Parameter 'force' implicitly has an 'any' type.
60(227,22): error TS7006: Parameter 'videoElement' implicitly has an 'any' type.
61(231,13): error TS7053: Element implicitly has an 'any' type (number index on {}).
62(236,30): error TS7006: Parameter 'width' implicitly has an 'any' type.
63(236,37): error TS7006: Parameter 'height' implicitly has an 'any' type.
64(247,28): error TS7053: Element implicitly has an 'any' type (number index on {}).
65(247,68): error TS7053: Element implicitly has an 'any' type (number index on {}).
66```
67 
68### `injected/src/features/duckplayer/overlay-messages.js` (4 errors)
69```
70(89,64): error TS2345: Argument of type '(userValues: UserValues) => void' is not assignable to parameter of type '(value: unknown) => void'.
71(97,62): error TS2345: Argument of type '(userValues: UISettings) => void' is not assignable to parameter of type '(value: unknown) => void'.
72(104,26): error TS7006: Parameter 'kind' implicitly has an 'any' type.
73(104,32): error TS7006: Parameter 'data' implicitly has an 'any' type.
74```
75 
76### `injected/src/features/duckplayer/thumbnails.js` (5 errors)
77```
78(105,35): error TS7006: Parameter 'e' implicitly has an 'any' type.
79(129,36): error TS7006: Parameter 'element' implicitly has an 'any' type.
80(136,39): error TS7006: Parameter 'e' implicitly has an 'any' type.
81(203,35): error TS7006: Parameter 'e' implicitly has an 'any' type.
82(207,32): error TS7006: Parameter 'href' implicitly has an 'any' type.
83```
84 
85### `injected/src/features/duckplayer/util.js` (10 errors)
86```
87(210,25): error TS7006: Parameter 'pathname' implicitly has an 'any' type.
88(227,21): error TS7006: Parameter 'href' implicitly has an 'any' type.
89(268,5): error TS7008: Member 'loadedCallbacks' implicitly has an 'any[]' type.
90(276,14): error TS7006: Parameter 'loadedCallback' implicitly has an 'any' type.
91(301,11): error TS7019: Rest parameter 'args' implicitly has an 'any[]' type.
92(305,10): error TS7019: Rest parameter 'args' implicitly has an 'any[]' type.
93(309,9): error TS7019: Rest parameter 'args' implicitly has an 'any[]' type.
94(313,10): error TS7019: Rest parameter 'args' implicitly has an 'any[]' type.
95(317,12): error TS7006: Parameter 'handler' implicitly has an 'any' type.
96(317,21): error TS7006: Parameter 'args' implicitly has an 'any' type.
97```
98 
99### `injected/src/features/duckplayer/video-overlay.js` (4 errors)
100```
101(256,18): error TS2769: No overload matches this call.
102(259,18): error TS2769: No overload matches this call.
103(291,24): error TS2769: No overload matches this call.
104(300,24): error TS2769: No overload matches this call.
105```
106 
107## Fix Patterns
108 
109- **TS7006/TS7019** (Parameter/rest implicitly any): Add `@param` JSDoc. For rest params: `@param {...unknown[]} args`.
110- **TS2564** (No initializer): Add definite assignment assertion `!` or initialize in declaration.
111- **TS2339** (Property on Object): Cast param to proper shape or define `@typedef`.
112- **TS7053** (Index signature): Cast objects to `Record<number, X>` or use proper array types.
113- **TS2345** (subscribe callback type): The subscribe API expects `(value: unknown) => void`. Either cast the callback or add a type guard inside.
114- **TS2769** (No overload matches): Check addEventListener/removeEventListener calls — likely need to narrow the event type string or cast.
115- **TS7008** (Member implicitly any): Add `@type` annotation to class member.
116 
117## Workflow
118 
1191. `npm ci`
1202. Add all 9 files to CORE_FILES in `scripts/check-strict-core.js`
1213. Fix each file's errors
1224. `npm run tsc-strict-core` — must pass
1235. `npm run test-unit` — must pass
1246. `npm run lint` — must pass (run `npm run lint-fix` first if needed)
1257. Commit: `fix(types): add strict checking for duckplayer files`
1268. `git push -u origin cursor/strict/duckplayer`
127 
128## Constraints
129 
130- Do NOT use `any` — use `unknown`, specific types, or proper interfaces
131- Do NOT use `@ts-ignore` or `@ts-expect-error`
132- Do NOT modify files outside the assigned list (except `scripts/check-strict-core.js`)
133- Do NOT remove existing CORE_FILES entries
134- Preserve existing behavior — type fixes only, no logic changes
135