Cursor rule

1---
2description: "Subagent task: Fix strict TypeScript errors in detector files and add to CORE_FILES"
3globs:
4  - "scripts/check-strict-core.js"
5  - "injected/src/detectors/detections/adwall-detection.js"
6  - "injected/src/detectors/detections/bot-detection.js"
7  - "injected/src/detectors/detections/youtube-ad-detection.js"
8  - "injected/src/detectors/utils/detection-utils.js"
9---
10 
11# Strict TypeScript: Detectors
12 
13## Task
14 
15Fix all strict-mode TypeScript errors in 4 detector files and add them to `CORE_FILES`.
16 
17## Branch
18 
19```
20git checkout main && git pull origin main && git checkout -b cursor/strict/detectors
21```
22 
23## Files (17 errors total)
24 
25### `injected/src/detectors/detections/adwall-detection.js` (2 errors)
26```
27(55,13): error TS2339: Property 'textPatterns' does not exist on type '{}'.
28(55,27): error TS2339: Property 'textSources' does not exist on type '{}'.
29```
30 
31### `injected/src/detectors/detections/bot-detection.js` (1 error)
32```
33(33,21): error TS7006: Parameter 'statusSelectors' implicitly has an 'any' type.
34```
35 
36### `injected/src/detectors/detections/youtube-ad-detection.js` (12 errors)
37```
38(57,9): error TS7022: 'trackedVideoElement' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
39(58,9): error TS7022: 'lastLoggedVideoId' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
40(64,9): error TS7022: 'playerRoot' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
41(116,26): error TS2339: Property 'message' does not exist on type 'Object'.
42(116,47): error TS2339: Property 'lastMessage' does not exist on type union.
43(116,71): error TS2339: Property 'message' does not exist on type 'Object'.
44(121,53): error TS2339: Property 'message' does not exist on type 'Object'.
45(125,21): error TS2339: Property 'message' does not exist on type 'Object'.
46(126,45): error TS2339: Property 'message' does not exist on type 'Object'.
47(333,32): error TS2339: Property 'maxLength' does not exist on type 'Object'.
48(334,48): error TS2339: Property 'checkAttributedStrings' does not exist on type 'Object'.
49(335,45): error TS2339: Property 'checkDialogFallback' does not exist on type 'Object'.
50```
51 
52### `injected/src/detectors/utils/detection-utils.js` (2 errors)
53```
54(34,54): error TS7015: Element implicitly has an 'any' type because index expression is not of type 'number'.
55(62,36): error TS7053: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Element'.
56```
57 
58## Fix Patterns
59 
60- **TS2339** (Property doesn't exist on type): Add JSDoc `@typedef` or `@type` cast before accessing properties. For `Object` typed params, define an interface via `@typedef` or cast with `/** @type {{prop: type}} */`.
61- **TS7006** (Parameter implicitly any): Add `@param {Type}` JSDoc annotations.
62- **TS7022** (Variable implicitly any due to circular ref): Add explicit `/** @type {Type} */` annotation at declaration.
63- **TS7015/TS7053** (No index signature): Use `/** @type {Record<string, X>} */` cast or narrow the index type.
64 
65## Workflow
66 
671. `npm ci`
682. Add all 4 files to CORE_FILES in `scripts/check-strict-core.js`
693. Fix each file's errors using JSDoc type annotations (no `any`, no `@ts-ignore`)
704. `npm run tsc-strict-core` — must pass
715. `npm run test-unit` — must pass
726. `npm run lint` — must pass (run `npm run lint-fix` first if needed)
737. Commit: `fix(types): add strict checking for detector files`
748. `git push -u origin cursor/strict/detectors`
75 
76## Constraints
77 
78- Do NOT use `any` — use `unknown`, specific types, or proper interfaces
79- Do NOT use `@ts-ignore` or `@ts-expect-error`
80- Do NOT modify files outside the assigned list (except `scripts/check-strict-core.js`)
81- Do NOT remove existing CORE_FILES entries
82- Preserve existing behavior — type fixes only, no logic changes
83