Copilot instructions

1---
2description: 'Learned project conventions and pitfalls from agent sessions.'
3applyTo: '**'
4---
5 
6# Project Conventions (Learned)
7 
8This always-on file is a router. Detailed cross-cutting rules live in
9[AGENT-PROTOCOL.md](../AGENT-PROTOCOL.md); agent definitions MUST link to that file
10instead of repeating it.
11 
12## Required Rules
13 
14- Before any code/docs mutation, start the quality loop as the first tool call.
15	Minimum: five evidenced iterations, including a subagent review summary containing
16	`review`, then `loop complete`. Check `loop status` before reporting gate state.
17- Load and follow the Karpathy guidelines for implementation/review. Run
18	`.agentx/agentx.ps1 scrub -Path <changed-area>` before review or handoff.
19- Engineer work follows `Research -> Brainstorm -> Plan -> Design -> Implement ->
20	Scrub -> Test -> Review`. Record alternatives before Plan.
21- New ADRs require a matching Model Council artifact. Approved reviews require
22	matching learning capture or the documented skip rationale. Changes to eight or
23	more code files require an execution plan or documented skip token.
24- UI work defaults to browser validation: primary routes, axe scan, and one primary
25	interaction. Report unavailable browser prerequisites instead of silently skipping.
26- Agent `model:` fields and named council models are advisory. Preserve role behavior
27	across capable models and preserve each agent's tool/permission boundaries.
28- AgentX is zero-copy. Initialize through `agentx.initializeLocalRuntime`; never copy
29	bundled agent, skill, instruction, template, guide, or prompt trees into a workspace.
30 
31## Working Conventions
32 
33- Prefer small `apply_patch` edits with enough context to identify the target.
34- After structural edits, search for removed identifiers and run the narrowest
35	executable check before widening validation.
36- PowerShell `ConvertTo-Json` can flatten single-element arrays; wrap with `@(...)`.
37- Passing unit tests does not replace validation of UI, wiring, or release boundaries.
38- Keep durable decisions and pitfalls concise in `/memories/`; keep this router short.
39 
40## References
41 
42- [.github/AGENT-PROTOCOL.md](../AGENT-PROTOCOL.md)
43- [docs/WORKFLOW.md](../../docs/WORKFLOW.md)
44- [AGENTS.md](../../AGENTS.md)
45- `/memories/conventions.md`, `/memories/decisions.md`, `/memories/pitfalls.md`
46 
47