Copilot instructions

1# Source code review rules
2 
3Applies to: src/**/*.cs
4 
5These rules apply when reviewing production source code in this repository.
6 
7## Namespace resolution — do NOT flag
8 
9- `Client.AppConfig.X`, `Client.Internal.X`, and similar short namespace references resolve via parent namespace `Microsoft.Identity`. Do not flag as unresolved.
10 
11## ConcurrentDictionary.GetOrAdd
12 
13`GetOrAdd(key, value)` eagerly evaluates the value argument. Flag any call where the second argument is not a delegate/lambda/method group:
14 
15- Bad: `pool.GetOrAdd(key, new ExpensiveObject());`
16- Good: `pool.GetOrAdd(key, _ => new ExpensiveObject());`
17 
18## `ConfigureAwait(false)`
19 
20`ConfigureAwait(false)` is intentional in library code. Do not suggest removal.
21 
22## Public API changes
23 
24- Any public API additions or removals must be reflected in `PublicAPI.Unshipped.txt`
25- XML doc comments are required on all public APIs
26- Maintain backward compatibility — breaking changes require explicit justification
27 
28## MSAL-specific
29 
30- Keep dependencies minimal and well-justified
31 
32## Scope
33 
34- Only comment on source code added or modified in the PR diff
35- Do not comment on pre-existing code unless the PR directly introduces the issue
36- Do not comment on style or formatting — coding standards are enforced via .editorconfig
37- Focus on: bugs, security issues, logic errors, API contract violations
38